Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agat sq stat basic #110

Merged
merged 18 commits into from
Nov 2, 2024
Merged

Add agat sq stat basic #110

merged 18 commits into from
Nov 2, 2024

Conversation

Leila011
Copy link
Contributor

@Leila011 Leila011 commented Aug 1, 2024 •
edited
Loading

Description

add agat_sq_stat_basic

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Leila011
Copy link
Contributor Author

Leila011 commented Aug 1, 2024 •
edited
Loading

Questions:

  1. Did I handled the situation with the argument --genome correctly: this argument can have both type file and integer. So I created two arguments, one for each type.
  2. Should those arguments (``genome_sizeandgenome_size_fasta`) be in the section Input and have the tag `direction = input` .

@Leila011 Leila011 requested a review from rcannood August 1, 2024 15:33
rcannood
rcannood approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood marked this pull request as ready for review November 2, 2024 09:25
@rcannood rcannood merged commit cc67547 into main Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leila011 @rcannood